[llvm-commits] [llvm] r164051 - /llvm/trunk/lib/Target/Mips/Mips16FrameLowering.cpp

[Hatanaka, Akira]

Reverted this patch in r164150.

________________________________________
From: Bill Wendling [wendling at apple.com]
Sent: Monday, September 17, 2012 2:26 PM
To: Hatanaka, Akira
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r164051 - /llvm/trunk/lib/Target/Mips/Mips16FrameLowering.cpp

On Sep 17, 2012, at 2:12 PM, "Hatanaka, Akira" <ahatanaka at mips.com> wrote:

> Yes, you are right.
>
> Reed is saying that he didn't remove the if statement because the code which was added is a temporary fix that will be removed once he makes the changes to correctly use save/restore instructions in function prologue/epilogue.
>
> Is that okay with you?

I just threw up a little. We normally don't apply temporary fixes (i.e. hacks) if there's a "real" fix coming down the pike. Is this blocking something important? How long until the real fix is ready? If this isn't blocking anything, then you should remove this hack and wait for the real fix.

-bw