[llvm-commits] [PATCH] Set needed target on debuginfo tests

Adhemerval Zanella azanella at linux.vnet.ibm.com
Tue Sep 18 05:51:41 PDT 2012


On 09/17/2012 09:28 PM, NAKAMURA Takumi wrote:
> 2012/9/18 Adhemerval Zanella <azanella at linux.vnet.ibm.com>:
>> Trivial patch to avoid make check-all errors when target 'x86-64-macosx' is
>> not configured.
>>  test/DebugInfo/2010-04-13-PubType.ll |    1 +
>>  test/DebugInfo/linkage-name.ll       |    1 +
>>  2 files changed, 2 insertions(+), 0 deletions(-)
> Could they be move to test/DebugInfo/X86?
>
> +; REQUIRES: x86-64-macosx-registered-target
>
> FYI, I don't think llvm/test/lit.cfg would provide such a feature.
> (or Did I miss other patchset?)
> Then, they might be eventually suppressed.
>
> ...Takumi
>
I'd say the better approach might be moving these to the specific folder,
however the REQUIRE feature seemed to work in my environment. I had only the
powerpc backend built in this seems to avoid the test check error.


-- 
Adhemerval Zanella Netto
  Software Engineer
  Linux Technology Center Brazil
  Toolchain / GLIBC on Power Architecture
  azanella at linux.vnet.ibm.com / azanella at br.ibm.com
  +55 61 8642-9890




More information about the llvm-commits mailing list