[llvm-commits] [llvm] r163216 - in /llvm/trunk/tools/lli: RecordingMemoryManager.cpp RecordingMemoryManager.h RemoteTarget.cpp RemoteTarget.h lli.cpp

[Jim Grosbach]

On Sep 6, 2012, at 5:42 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:

> Jim,
> 
>> Added: llvm/trunk/tools/lli/RemoteTarget.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lli/RemoteTarget.cpp?rev=163216&view=auto
> 
>> +#include <llvm/ADT/StringRef.h>
>> +#include <llvm/Support/Memory.h>
> 
>> Added: llvm/trunk/tools/lli/RemoteTarget.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lli/RemoteTarget.h?rev=163216&view=auto
> 
>> +#include <llvm/ADT/StringRef.h>
>> +#include <llvm/ADT/SmallVector.h>
>> +#include <llvm/Support/Memory.h>
> 
> About #include <llvm/...>, are they intentional? I guessed they might
> be exported outside the tree in future…

Hi Takumi,

I'm not sure I follow. This is just using the standard ADT classes in the 'lli' tool, so we include the relevant headers. What do you mean by "exported outside the tree?"

-Jim