[llvm-commits] [compiler-rt] r163923 - in /compiler-rt/trunk: SDKs/darwin/usr/include/stdio.h lib/profile/GCDAProfiling.c

[Hans Wennborg]

On Mon, Sep 17, 2012 at 12:02 PM, Saša Tomić <tomic80 at gmail.com> wrote:
> On 09/17/2012 12:25 PM, Benjamin Kramer wrote:
>>
>> On 17.09.2012, at 11:22, Saša Tomić <tomic80 at gmail.com> wrote:
>>
>>> This commit breaks the build on my machines (x86_64):
>>>
>> Committed a fix in r164025. Let me know if it's still broken.
>>
>> - Ben
>>
>
> Still a minor bug left:
>
>
> /home/stomic/projects/llvm/projects/compiler-rt/lib/profile/GCDAProfiling.c:256:53:
> error: format specifies type 'long long' but the argument has type
> 'uint64_t'
>       (aka 'unsigned long') [-Werror,-Wformat]
>   COMPILE:   clang_linux/asan-x86_64/x86_64:
> /home/stomic/projects/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cc
>
>       fprintf(stderr, "old counter[%d]: %lld\n", j, old_ctrs[j]);
>                                         ~~~~        ^~~~~~~~~~~
>                                         %ld
> 1 error generated.

That looks more like a bug in Clang's printf format checker. I think
using %lld for a uint64_t is perfectly reasonable.