[llvm-commits] ELFReader.cpp update - Add support for References.

[Michael Spencer]

On Fri, Sep 14, 2012 at 6:33 PM, Michael Spencer <bigcheesegs at gmail.com> wrote:
> On Fri, Sep 14, 2012 at 6:17 PM, Sid Manning <sidneym at codeaurora.org> wrote:
>> If all the functions are to be marked final then why not just mark the class
>> as final, "class ELFReference final : public Reference", I marked all of
>> these final.  What criteria is used in deciding when to mark a function
>> final?  It seems like many of the Atom functions could be marked as final
>> too.
>
> Yes, the class should be marked final. Also the ELFxAtom classes
> should be marked as final.
>
> - Michael Spencer

Oh, and with these changes the patch looks good.

- Michael Spencer