[llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.

[Chandler Carruth]

On Fri, Sep 14, 2012 at 1:54 PM, Bill Wendling <wendling at apple.com> wrote:

> I saw that too, but it was like that in the std::for_each's before it, so
> I didn't bother to pester Jan. :-)
>

This is what I get for only looking at the touched lines. =]


>
> -bw
>
> On Sep 14, 2012, at 1:51 PM, Chandler Carruth <chandlerc at google.com>
> wrote:
>
> > Glorious and wonderful with one nit:
> >
> > +  if (!WithoutAliases)
> > +    std::for_each (M->alias_begin(), M->alias_end(),
> > +                DumpSymbolNameForGlobalValue);
> >
> > No space between 'std::for_each' and the '('. Functions and if
> statements are different for LLVM's style...
> >
> >
> > On Fri, Sep 14, 2012 at 7:46 AM, Jan Sjodin <jan_sjodin at yahoo.com>
> wrote:
> > New patch with fixed indentation and test case (includes both with and
> without the new flag).
> >
> > - Jan
> >
> > From: Chandler Carruth <chandlerc at google.com>
> > To: "Villmow, Micah" <Micah.Villmow at amd.com>
> > Cc: Jan Sjodin <jan_sjodin at yahoo.com>; "llvm-commits at cs.uiuc.edu" <
> llvm-commits at cs.uiuc.edu>
> > Sent: Thursday, September 13, 2012 5:34 PM
> >
> > Subject: Re: [llvm-commits] Patch to add hidden flag to llvm-nm to not
> emit aliases.
> >
> > On Thu, Sep 13, 2012 at 2:21 PM, Villmow, Micah <Micah.Villmow at amd.com>
> wrote:
> > As far as I can tell, most basic tools have no test cases, are there
> examples?
> >
> > test/Other/optimize-options.ll
> >
> >
> > From: Chandler Carruth [mailto:chandlerc at google.com]
> > Sent: Thursday, September 13, 2012 2:17 PM
> > To: Villmow, Micah
> > Cc: Jan Sjodin; llvm-commits at cs.uiuc.edu
> > Subject: Re: [llvm-commits] Patch to add hidden flag to llvm-nm to not
> emit aliases.
> >
> > On Thu, Sep 13, 2012 at 2:10 PM, Villmow, Micah <Micah.Villmow at amd.com>
> wrote:
> > LGTM
> >
> > No, this patch isn't ready to go in yet.
> >
> > It has no test case updates, and it doesn't even indent things properly.
> >
> >
> > From: llvm-commits-bounces at cs.uiuc.edu [mailto:
> llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Jan Sjodin
> > Sent: Thursday, September 13, 2012 1:41 PM
> > To: llvm-commits at cs.uiuc.edu
> > Subject: [llvm-commits] Patch to add hidden flag to llvm-nm to not emit
> aliases.
> >
> > Hi, I posted in llvm-dev some time back about adding a -without-aliases
> flag that will not include aliases in the output. Here is the patch. Okay
> to commit?
> >
> > - Jan
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> >
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120914/68abe603/attachment.html>