[llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.

Bill Wendling wendling at apple.com
Fri Sep 14 13:49:17 PDT 2012


LGTM.

-bw

On Sep 14, 2012, at 7:46 AM, Jan Sjodin <jan_sjodin at yahoo.com> wrote:

> New patch with fixed indentation and test case (includes both with and without the new flag).
> 
> - Jan
> 
> From: Chandler Carruth <chandlerc at google.com>
> To: "Villmow, Micah" <Micah.Villmow at amd.com> 
> Cc: Jan Sjodin <jan_sjodin at yahoo.com>; "llvm-commits at cs.uiuc.edu" <llvm-commits at cs.uiuc.edu> 
> Sent: Thursday, September 13, 2012 5:34 PM
> Subject: Re: [llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.
> 
> On Thu, Sep 13, 2012 at 2:21 PM, Villmow, Micah <Micah.Villmow at amd.com> wrote:
> As far as I can tell, most basic tools have no test cases, are there examples?
> 
> test/Other/optimize-options.ll
>  
>  
> From: Chandler Carruth [mailto:chandlerc at google.com] 
> Sent: Thursday, September 13, 2012 2:17 PM
> To: Villmow, Micah
> Cc: Jan Sjodin; llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.
>  
> On Thu, Sep 13, 2012 at 2:10 PM, Villmow, Micah <Micah.Villmow at amd.com> wrote:
> LGTM
>  
> No, this patch isn't ready to go in yet.
>  
> It has no test case updates, and it doesn't even indent things properly.
>  
>  
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Jan Sjodin
> Sent: Thursday, September 13, 2012 1:41 PM
> To: llvm-commits at cs.uiuc.edu
> Subject: [llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.
>  
> Hi, I posted in llvm-dev some time back about adding a -without-aliases flag that will not include aliases in the output. Here is the patch. Okay to commit?
>  
> - Jan
>  
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>  
> 
> 
> 
> <0062_llvm_nm_wo_aliases.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list