[llvm-commits] [llvm] r163757 - /llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp

[Bill Wendling]

On Sep 13, 2012, at 9:19 AM, Bob Wilson <bob.wilson at apple.com> wrote:

> I'm not seeing the code to read the counter values from the files.  Am I missing that somewhere?  GCC's version of __gcov_flush is designed to let you call it multiple times during a program execution.  Each time it adds the current counters to the values already in the output files, writes the new values out, and zeros the counters again.  It's like fflush() -- you can call it at any point to flush the data out.  That seems like a nice design.
> 
Okay. That will take a lot more doing...We aren't really set up to handle that. :-( 

> Also, what is the advantage of calling this __llvm_gcov_flush instead of just __gcov_flush?  Since the name of this function is exposed to users, we should keep the same name unless there's a good reason to differ.
> 
There's a precedent for appending __llvm to the name...I was just following that.

-bw