[llvm-commits] [PATCH] Improve vmov domain conversion (followup)
Jakob Stoklund Olesen
stoklund at 2pi.dk
Tue Sep 11 09:51:15 PDT 2012
On Sep 11, 2012, at 5:25 AM, James Molloy <james.molloy at arm.com> wrote:
> Hi Jakob,
>
> Sorry this has takena few days to get back to you.
>
> I've moved analyzePhysReg into MachineOperandIteratorBase, and renamed
> "RegInfo" to "VirtRegInfo" so the physical and virtual query functions
> are complementary.
>
> I hope this is more satisfactory? :)
Yes, please break it into three separate patches.
I don't think the 'Ops' argument to analyzePhysReg() is needed. Please remove that and go ahead and commit that part.
The MachineBasicBlock:isRegisterLive() function looks fine, except for the name. It doesn't return a bool, so it shouldn't be called is*. I would suggest computePhysRegLiveness() instead. Then go ahead and commit that part as well.
As for the ARM-specific part, I don't think that is safe. If you can't determine the liveness of the other lane, the transform should be aborted.
/jakob
More information about the llvm-commits
mailing list