[llvm-commits] Patch to unify same code in multiple spots

[Villmow, Micah]

Ping

From: Villmow, Micah
Sent: Thursday, September 06, 2012 9:51 AM
To: 'Duncan Sands'; 'llvm-commits at cs.uiuc.edu'
Subject: RE: [llvm-commits] Patch to unify same code in multiple spots

Here is an updated patch with this feedback.

From: llvm-commits-bounces at cs.uiuc.edu<mailto:llvm-commits-bounces at cs.uiuc.edu> [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Duncan Sands
Sent: Wednesday, July 25, 2012 1:00 AM
To: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
Subject: Re: [llvm-commits] Patch to unify same code in multiple spots

This message has been archived. View the original item <http://ausev2.amd.com/EnterpriseVault/ViewMessage.asp?VaultId=12070563DD2F0FE4F9324523BDD9809741110000amdvault.amd.com&SavesetId=201208255869093~201207250801030000~Z~2154F2EFF0A845883AE59EF8A0C8DDB1>

Hi Micah, instead of the prefix/suffix logic, why not do this:

...
    } else if (const CallInst *CI = dyn_cast<CallInst>(&I)) {
      // Print the calling convention being used.
      if (CI->getCallingConv() != CallingConv::C) // The default
        PrintCallingConv(F->getCallingConv(), Out);
...
?

Ciao, Duncan.
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 22503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120911/fd8e0e7c/attachment.bin>