[llvm-commits] [llvm] r163242 - /llvm/trunk/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp

[Jan Voung]

Hi Duncan,

Just to be clear, are you referring to my messy series of changes
(see Craig's reply), which turns out to be PR12301, or are you
referring to the not-so-descriptive "Fix a bug."?

In any case, it's all related, and attached is a test for the
llvm-bcanalyzer
change (to be put in test/Bitcode/).

I'm not sure though how much of the formatting we want to enforce,
but what's in the test seemed reasonable.

- Jan


On Sun, Sep 9, 2012 at 7:36 AM, Duncan Sands <baldrick at free.fr> wrote:

> Hi Jan,
>
>
> On 05/09/12 22:56, Jan Wen Voung wrote:
>
>> Author: jvoung
>> Date: Wed Sep  5 15:56:00 2012
>> New Revision: 163242
>>
>> URL: http://llvm.org/viewvc/llvm-**project?rev=163242&view=rev<http://llvm.org/viewvc/llvm-project?rev=163242&view=rev>
>> Log:
>> Fix a bug.
>>
>
> testcase?
>
> Ciao, Duncan.
>
>
>
>> Modified:
>>      llvm/trunk/tools/llvm-**bcanalyzer/llvm-bcanalyzer.cpp
>>
>> Modified: llvm/trunk/tools/llvm-**bcanalyzer/llvm-bcanalyzer.cpp
>> URL: http://llvm.org/viewvc/llvm-**project/llvm/trunk/tools/llvm-**
>> bcanalyzer/llvm-bcanalyzer.**cpp?rev=163242&r1=163241&r2=**
>> 163242&view=diff<http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp?rev=163242&r1=163241&r2=163242&view=diff>
>> ==============================**==============================**
>> ==================
>> --- llvm/trunk/tools/llvm-**bcanalyzer/llvm-bcanalyzer.cpp (original)
>> +++ llvm/trunk/tools/llvm-**bcanalyzer/llvm-bcanalyzer.cpp Wed Sep  5
>> 15:56:00 2012
>> @@ -592,7 +592,7 @@
>>         for (unsigned i = 0, e = FreqPairs.size(); i != e; ++i) {
>>           const PerRecordStats &RecStats = Stats.CodeFreq[FreqPairs[i].**
>> second];
>>
>> -        outs() << format("\t\t%7d %9.2f",
>> +        outs() << format("\t\t%7d %9lu",
>>                            RecStats.NumInstances,
>>                            (unsigned long)RecStats.TotalBits);
>>
>>
>>
>> ______________________________**_________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/**mailman/listinfo/llvm-commits<http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>>
>>
> ______________________________**_________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/**mailman/listinfo/llvm-commits<http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120910/1de22346/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-bcanalyzer-stdout.ll
Type: application/octet-stream
Size: 1087 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120910/1de22346/attachment.obj>