[llvm-commits] [llvm] r163339 - in /llvm/trunk/lib: CodeGen/ CodeGen/SelectionDAG/ Target/X86/

[Duncan Sands]

PS: I just understood that Chandler is talking about debugging in the sense of
   DEBUG(XYZ->dump());
lines inside the LLVM code base, while I was talking about debugging from within
the debugger.  Chandler's use case is of course much more common than mine.

It is clear that ->dump() has to be available if DEBUG(...) macros are turned
on.  That means that !NDEBUG has to turn on LLVM_ENABLE_DUMP, since !NDEBUG
enables DEBUG(...).

So I now agree with Chandler: !NDEBUG should turn on LLVM_ENABLE_DUMP, however
there should be a way of explicitly asking for LLVM_ENABLE_DUMP to be turned
on even if NDEBUG, by passing some option to configure.

Ciao, Duncan.