[llvm-commits] [compiler-rt] r163411 - /compiler-rt/trunk/lib/asan/asan_report.cc

[Richard Smith]

On Fri, Sep 7, 2012 at 1:23 PM, Daniel Dunbar <daniel at zuster.org> wrote:

> On Friday, September 7, 2012, Chandler Carruth wrote:
>
>> On Fri, Sep 7, 2012 at 3:57 PM, Daniel Dunbar <daniel at zuster.org> wrote:
>>
>>> Author: ddunbar
>>> Date: Fri Sep  7 14:57:20 2012
>>> New Revision: 163411
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=163411&view=rev
>>> Log:
>>> [asan] Suppress some bogus -Winvalid-noreturn diagnostics.
>>>
>>
>> Please no. This is not the right way to suppress these. This code is hard
>> enough to read w/o adding pragmas to the mix.
>>
>> If this warning is bogus, we should fix the warning.
>>
>
> The warning is not bogus, but I don't think we are going to fix Clang to
> detect the situation where the RAII object destructor causes a noreturn.
>

We don't even *need* to fix Clang. It already handles that situation if you
mark the destructor as noreturn.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120907/4e07f07e/attachment.html>