[llvm-commits] [llvm] r163339 - in /llvm/trunk/lib: CodeGen/ CodeGen/SelectionDAG/ Target/X86/

[Manman Ren]

On Sep 7, 2012, at 11:36 AM, Bill Wendling <wendling at apple.com> wrote:

> On Sep 7, 2012, at 9:38 AM, Duncan Sands <baldrick at free.fr> wrote:
> 
>> Hi Craig,
>> 
>> On 07/09/12 18:18, Craig Topper wrote:
>>> Wouldn't dead code stripping in the linker have removed these from a released build?
>> 
>> good question, but it seems not since I regularly use these when debugging
>> release build problems on linux (usually buildbot crashes).  (I don't have
>> time to look into why they aren't removed right now, sorry).  If it was the
>> case that the linker removes them then Manman's patch wouldn't really be
>> needed :)
>> 
> If you need them, then we should think of another method for removing them that works for us but doesn't affect your stuff.
> 
> Manman, what do you think of having a flag, say REMOVE_DUMP, instead of using NDEBUG?
Works for me.

-Manman
> 
> -bw
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits