[llvm-commits] [PATCH] Heuristic changes to Hexagon MI scheduler

[Sergei Larin]

Andy, 

  Thanks for the detailed review. I'll take a closer look at SUnit interface
when I am back in Austin, and will probably check it in by Monday.
As for the short term plans - yes I do plan to diverge in reg pressure
heuristics details a bit more, so duplication in that area should be
beneficial.

Thanks again.

Sergei

---
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


> -----Original Message-----
> From: Andrew Trick [mailto:atrick at apple.com]
> Sent: Thursday, September 06, 2012 7:43 PM
> To: Sergei Larin
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [PATCH] Heuristic changes to Hexagon MI
> scheduler
> 
> Hi Sergei,
> 
> NumPreds/SuccsLeft are public members of SUnit. So I don't think you
> need getSingleUnscheduledPred/Succ helpers. In this case you already
> know that the Pred/Succ is unscheduled, so you can just check the
> count.
> 
> Other than that, please check it in. As soon as you do, I'll reorganize
> MachineScheduler.h to remove a lot of the redundancy.  After my reorg,
> MachineSchedStrategy and ScheduleDAGMI will become public, but
> ConvergingScheduler will still be local. It will look like you still
> have redundant code in the register pressure heuristics, but that's
> actually what I want. I'll be changing those frequently in the near
> future and don't want to affect your target during the churn. I expect
> you to end up rewriting those heuristics eventually anyway to work
> better for VLIWish targets.
> 
> -Andy
> 
> On Sep 5, 2012, at 7:45 AM, Sergei Larin <slarin at codeaurora.org> wrote:
> 
> > Please review attached patch. It attempts to:
> >
> > - Add "blocked" heuristic to the Hexagon MI scheduler
> > - Tweak the Hexagon local class hierarchy a bit
> > - Clean-up couple minor stylistic violations
> >
> >  It passes make check-all without any additional issues.
> >
> > Thanks.
> >
> > Sergei Larin
> >
> > ---
> > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> > hosted by The Linux Foundation
> >
> >
> <add_blocked_heuristic_to_Hexagon_MI_scheduler.patch>_________________
> > ______________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits