[llvm-commits] [PATCH] Fixes for ARM vst and vld instructions

Tim Northover t.p.northover at gmail.com
Thu Sep 6 08:22:09 PDT 2012


Hi Jim,

> LGTM in general, and resolving the MC Hammer failures is a really good sign.
>
> Small tweak I'd like is for the test cases to use register values other than zero
> (r0, d0). The encoding will default to zero even if we totally screw up mapping the
> register operand into the instruction encoding, so I prefer to use pretty much any
> other register. Many of the existing test cases are absolutely horrible examples in
> that regard. :(

Thanks. Chris has updated his patches with your comments and I've
committed them
for him as r163318 and r163321.

Regards.

Tim.



More information about the llvm-commits mailing list