[llvm-commits] [llvm] r163225 - in /llvm/trunk: include/llvm/ADT/Hashing.h include/llvm/Analysis/LoopInfoImpl.h include/llvm/SymbolTableListTraits.h lib/CodeGen/RegAllocPBQP.cpp lib/DebugInfo/DWARFDebugAranges.cpp

[Sean Silva]

Cool. As you collect the bigger patch, it would be nice if you kept a
diary of the different warnings you are fixing, and how useful they
seem, and then make a post to cfe-dev with the ones you think would be
most useful to implement.

--Sean Silva

On Wed, Sep 5, 2012 at 2:32 PM, Roman Divacky <rdivacky at freebsd.org> wrote:
> Probably it would be useful. It warns about typedefs that are
> not used. Btw, I am collecting bigger patch, to make us gcc48
> warnings clean.
>
> On Wed, Sep 05, 2012 at 02:29:21PM -0400, Sean Silva wrote:
>> What warning is this? Would it be valuable to have in Clang?
>>
>> On Wed, Sep 5, 2012 at 1:55 PM, Roman Divacky <rdivacky at freebsd.org> wrote:
>> > Author: rdivacky
>> > Date: Wed Sep  5 12:55:46 2012
>> > New Revision: 163225
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=163225&view=rev
>> > Log:
>> > Remove unused typedefs gcc4.8 warns about.
>> >
>> > Modified:
>> >     llvm/trunk/include/llvm/ADT/Hashing.h
>> >     llvm/trunk/include/llvm/Analysis/LoopInfoImpl.h
>> >     llvm/trunk/include/llvm/SymbolTableListTraits.h
>> >     llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp
>> >     llvm/trunk/lib/DebugInfo/DWARFDebugAranges.cpp
>> >
>> > Modified: llvm/trunk/include/llvm/ADT/Hashing.h
>> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/Hashing.h?rev=163225&r1=163224&r2=163225&view=diff
>> > ==============================================================================
>> > --- llvm/trunk/include/llvm/ADT/Hashing.h (original)
>> > +++ llvm/trunk/include/llvm/ADT/Hashing.h Wed Sep  5 12:55:46 2012
>> > @@ -409,7 +409,6 @@
>> >  /// combining them, this (as an optimization) directly combines the integers.
>> >  template <typename InputIteratorT>
>> >  hash_code hash_combine_range_impl(InputIteratorT first, InputIteratorT last) {
>> > -  typedef typename std::iterator_traits<InputIteratorT>::value_type ValueT;
>> >    const size_t seed = get_execution_seed();
>> >    char buffer[64], *buffer_ptr = buffer;
>> >    char *const buffer_end = buffer_ptr + array_lengthof(buffer);
>> >
>> > Modified: llvm/trunk/include/llvm/Analysis/LoopInfoImpl.h
>> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/LoopInfoImpl.h?rev=163225&r1=163224&r2=163225&view=diff
>> > ==============================================================================
>> > --- llvm/trunk/include/llvm/Analysis/LoopInfoImpl.h (original)
>> > +++ llvm/trunk/include/llvm/Analysis/LoopInfoImpl.h Wed Sep  5 12:55:46 2012
>> > @@ -145,7 +145,6 @@
>> >
>> >    // Loop over the predecessors of the header node...
>> >    BlockT *Header = getHeader();
>> > -  typedef GraphTraits<BlockT*> BlockTraits;
>> >    typedef GraphTraits<Inverse<BlockT*> > InvBlockTraits;
>> >    for (typename InvBlockTraits::ChildIteratorType PI =
>> >           InvBlockTraits::child_begin(Header),
>> >
>> > Modified: llvm/trunk/include/llvm/SymbolTableListTraits.h
>> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/SymbolTableListTraits.h?rev=163225&r1=163224&r2=163225&view=diff
>> > ==============================================================================
>> > --- llvm/trunk/include/llvm/SymbolTableListTraits.h (original)
>> > +++ llvm/trunk/include/llvm/SymbolTableListTraits.h Wed Sep  5 12:55:46 2012
>> > @@ -46,7 +46,6 @@
>> >    /// getListOwner - Return the object that owns this list.  If this is a list
>> >    /// of instructions, it returns the BasicBlock that owns them.
>> >    ItemParentClass *getListOwner() {
>> > -    typedef iplist<ValueSubClass> ItemParentClass::*Sublist;
>> >      size_t Offset(size_t(&((ItemParentClass*)0->*ItemParentClass::
>> >                             getSublistAccess(static_cast<ValueSubClass*>(0)))));
>> >      iplist<ValueSubClass>* Anchor(static_cast<iplist<ValueSubClass>*>(this));
>> >
>> > Modified: llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp
>> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp?rev=163225&r1=163224&r2=163225&view=diff
>> > ==============================================================================
>> > --- llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp (original)
>> > +++ llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp Wed Sep  5 12:55:46 2012
>> > @@ -192,7 +192,6 @@
>> >                                                  const MachineLoopInfo *loopInfo,
>> >                                                  const RegSet &vregs) {
>> >
>> > -  typedef std::vector<const LiveInterval*> LIVector;
>> >    LiveIntervals *LIS = const_cast<LiveIntervals*>(lis);
>> >    MachineRegisterInfo *mri = &mf->getRegInfo();
>> >    const TargetRegisterInfo *tri = mf->getTarget().getRegisterInfo();
>> >
>> > Modified: llvm/trunk/lib/DebugInfo/DWARFDebugAranges.cpp
>> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFDebugAranges.cpp?rev=163225&r1=163224&r2=163225&view=diff
>> > ==============================================================================
>> > --- llvm/trunk/lib/DebugInfo/DWARFDebugAranges.cpp (original)
>> > +++ llvm/trunk/lib/DebugInfo/DWARFDebugAranges.cpp Wed Sep  5 12:55:46 2012
>> > @@ -62,7 +62,6 @@
>> >      uint32_t offset = 0;
>> >
>> >      typedef std::vector<DWARFDebugArangeSet> SetCollection;
>> > -    typedef SetCollection::const_iterator SetCollectionIter;
>> >      SetCollection sets;
>> >
>> >      DWARFDebugArangeSet set;
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits