[llvm-commits] [PATCH 1/5] Fix arithmetic promotion rule in ELF.h

[Matt Beaumont-Gay]

On Wed, Sep 5, 2012 at 10:13 AM, Will Schmidt <will_schmidt at vnet.ibm.com> wrote:
> On Wed, 2012-09-05 at 13:00 -0300, Adhemerval Zanella wrote:
>> Fix for some arithmetic additions being handled as signed where it should
>> not. Also add the PPC64 triple definitions.
>
> The 0 to 0UL changes look reasonable to me.   Did you identify an
> existing testcase that fails/works with the signed change?   I didn't
> notice a difference out of 'gmake check-all' with/without this patch
> applied.
>
> May wish to break out the PPC64 triple change, I think it's mostly
> unrelated to the 0UL bits.

+1, please keep unrelated changes separate.