[llvm-commits] [PATCH] Execution domain support for VMOV and VLDR

Jakob Stoklund Olesen stoklund at 2pi.dk
Tue Sep 4 09:23:49 PDT 2012


On Sep 3, 2012, at 7:29 AM, Tim Northover <t.p.northover at gmail.com> wrote:

> Hi,
> 
>> Thanks for your help with all this. Committed as r163070.
> 
> I'm afraid one more issue has come up. I foolishly removed the old
> operands before performing the test for whether the transformation was
> valid. This left the MachineInstr completely empty when the
> transformation was unsafe and caused an abort.
> 
> Very sorry about that. I've attached a fix for this issue. Ok to commit?

Looks good, but please add -verify-machineinstrs to that test case.

For obvious fixes like this to your own code, it's OK to commit before review.

/jakob




More information about the llvm-commits mailing list