[llvm-commits] [llvm] r162855 - /llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp

[Bill Wendling]

On Aug 29, 2012, at 5:30 PM, Eric Christopher <echristo at apple.com> wrote:

> 
> On Aug 29, 2012, at 5:27 PM, Bill Wendling <isanbard at gmail.com> wrote:
> 
>> 
>> On Aug 29, 2012, at 5:21 PM, Eric Christopher <echristo at apple.com> wrote:
>> 
>>> 
>>> On Aug 29, 2012, at 1:30 PM, Bill Wendling <isanbard at gmail.com> wrote:
>>> 
>>>> Author: void
>>>> Date: Wed Aug 29 15:30:44 2012
>>>> New Revision: 162855
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=162855&view=rev
>>>> Log:
>>>> Use the full path to output the .gcda file.
>>>> 
>>>> This lets the user run the program from a different directory and still have the
>>>> .gcda files show up in the correct place.
>>>> <rdar://problem/12179524>
>>> 
>>> Not that I have an opinion over either location, but how is this versus Joshua's
>>> patch to clang?
>>> 
>> *Goes and looks*
>> 
>> It dovetails nicely with it, though they appear to be two different things. My change changes the place where the .gcda file is located. Joshua's change looks like it makes an absolute path out of the file that's being covered (a.o, for instance).
>> 
> 
> Ah. Makes sense. I'll get his other one.
> 
Wait! I'm wrong. (There's a first time for everything.) His patch covers (heh) my patch, and is probably much better. We should just do it the way he suggests.

-bw