[llvm-commits] [PATCH] Rework bit/bits value resolving in tblgen

[Jakob Stoklund Olesen]

On Aug 28, 2012, at 2:35 PM, Michael Liao <michael.liao at intel.com> wrote:

> This patch resolves bit/bits value by resolving initializer value first
> and get its bit value from the specified position by adding (or
> promoting) getBits() to all Init(s) and removing resolveBitReference().
> We unify bit/bits with other types and remove redundant logic.

Hi Michael,

Thanks for fixing this!

In the past I have noticed some pretty bad performance in TableGen because it is repeatedly evaluating an expression tree.

Does this patch help with that behavior? Did you measure the performance?

/jakob