[llvm-commits] [llvm] r162526 - in /llvm/trunk: lib/CodeGen/AsmPrinter/DIE.cpp lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp lib/CodeGen/AsmPrinter/DwarfCompileUnit.h lib/CodeGen/AsmPrinter/DwarfDebug.cpp test/DebugInfo/X86/concrete_out_of_line.ll te...

[Robinson, Paul]

> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp?rev=162526&r1=162525&r2=162526&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp Thu Aug 23 20:14:27 2012
> @@ -182,6 +182,12 @@
>  void DIEInteger::EmitValue(AsmPrinter *Asm, unsigned Form) const {
>    unsigned Size = ~0U;
>    switch (Form) {
> +  case dwarf::DW_FORM_flag_present:
> +    // Emit something to keep the lines and comments in sync.
> +    // FIXME: Is there a better way to do this?
> +    if (Asm->OutStreamer.hasRawTextSupport())
> +      Asm->OutStreamer.EmitRawText(StringRef(""));
> +    return;
>    case dwarf::DW_FORM_flag:  // Fall thru
>    case dwarf::DW_FORM_ref1:  // Fall thru
>    case dwarf::DW_FORM_data1: Size = 1; break;
> @@ -203,6 +209,8 @@
>  ///
>  unsigned DIEInteger::SizeOf(AsmPrinter *AP, unsigned Form) const {
>    switch (Form) {
> +  case dwarf::DW_FORM_flag_present: // Fall thru
> +    return 0;

That case doesn't actually fall thru?

>    case dwarf::DW_FORM_flag:  // Fall thru
>    case dwarf::DW_FORM_ref1:  // Fall thru
>    case dwarf::DW_FORM_data1: return sizeof(int8_t);