[llvm-commits] [llvm] r162657 - in /llvm/trunk: include/llvm/DebugInfo/DIContext.h lib/DebugInfo/DIContext.cpp lib/DebugInfo/DWARFContext.cpp lib/DebugInfo/DWARFContext.h lib/DebugInfo/DWARFDebugRangeList.cpp lib/DebugInfo/DWARFDebugRangeList.h t

[Eric Christopher]

> +bool DWARFDebugRangeList::extract(DataExtractor data, uint32_t *offset_ptr) {
> +  clear();
> +  if (!data.isValidOffset(*offset_ptr))

Another nitpick, this (all of the DebugInfo stuff) code largely doesn't conform to the coding standards (variable names especially) but if you could avoid putting more stuff in that doesn't conform when you add new files it'd be nice.

Also might want to think about starting to add some test cases (I'm guilty of not doing it as well, but a thought).

Thanks!

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120827/5153d212/attachment.html>