[llvm-commits] CMake build rules for ASan/Android runtime. (issue 6475069)

[eugenis at google.com]

https://codereview.appspot.com/6475069/diff/1/CMakeLists.txt
File CMakeLists.txt (right):

https://codereview.appspot.com/6475069/diff/1/CMakeLists.txt#newcode52
CMakeLists.txt:52: if(EXISTS
${LLVM_ANDROID_TOOLCHAIN_DIR}/lib/gcc/arm-linux-androideabi)
On 2012/08/27 14:01:45, samsonov wrote:
> Hm-m-m, does Android toolchain dir always have
> lib/gcc/ in it, or it can sometimes have lib/clang/?
> That is, do we need separate CMake variable for this path?

In the distant future we can, theoretically, lose lib/gcc. This is
something Clang driver must detect.

I've changed the path to something that does not mention gcc.

https://codereview.appspot.com/6475069/diff/1/CMakeLists.txt#newcode60
CMakeLists.txt:60: # TODO: support i686 and MIPS Android toolchains
On 2012/08/27 14:01:45, samsonov wrote:
> Maybe you can add set(CAN_TARGET_ARM_ANDROID 0) to elseif()?

Done.

https://codereview.appspot.com/6475069/