[llvm-commits] [Please review][PATCH] Implement the block_iterator of Region based on df_iterator.

[Tobias Grosser]

On 08/27/2012 05:06 AM, Hongbin Zheng wrote:
> Hi,
>
> I attached a patch that make the function "Region::print" use the
> newly introduced block_iterator instead of the block_node_iterator.
> With this patch, the block_iterator is actually tested by the regression tests.

Does this mean the block_node_iterator is now untested? If that is the 
case we should either remove it add tests that ensure that it is still 
tested.

Otherwise, adding printing and testing for the block_iterator itself 
sounds like a good addition. Also switching the default to the 
block_iterator seems fine.

Tobi