[llvm-commits] [llvm] r162505 - /llvm/trunk/lib/Support/APFloat.cpp
Richard Smith
richard-llvm at metafoo.co.uk
Thu Aug 23 17:01:20 PDT 2012
Author: rsmith
Date: Thu Aug 23 19:01:19 2012
New Revision: 162505
URL: http://llvm.org/viewvc/llvm-project?rev=162505&view=rev
Log:
Fix undefined behavior (signed integer overflow) when Clang parses a hexfloat with an enormous exponent. Caught by an existing unit test + -ftrapv.
Modified:
llvm/trunk/lib/Support/APFloat.cpp
Modified: llvm/trunk/lib/Support/APFloat.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/APFloat.cpp?rev=162505&r1=162504&r2=162505&view=diff
==============================================================================
--- llvm/trunk/lib/Support/APFloat.cpp (original)
+++ llvm/trunk/lib/Support/APFloat.cpp Thu Aug 23 19:01:19 2012
@@ -196,8 +196,10 @@
assert(value < 10U && "Invalid character in exponent");
unsignedExponent = unsignedExponent * 10 + value;
- if (unsignedExponent > 32767)
+ if (unsignedExponent > 32767) {
overflow = true;
+ break;
+ }
}
if (exponentAdjustment > 32767 || exponentAdjustment < -32768)
More information about the llvm-commits
mailing list