[llvm-commits] [llvm] r162301 - in /llvm/trunk: foo lib/CodeGen/RegAllocGreedy.cpp

Craig Topper craig.topper at gmail.com
Tue Aug 21 19:28:42 PDT 2012


Something like this? Do I need to check if the MachineFunction has a valid
Function the way MachineBasicBlock checks and returns "(null)"? None of the
callers I replaced seemed to be checking for a valid result from
getFunction().

On Tue, Aug 21, 2012 at 5:06 PM, Craig Topper <craig.topper at gmail.com>wrote:

> I'll work on this tonight.
>
>
> On Tue, Aug 21, 2012 at 1:25 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:
>
>>
>> On Aug 21, 2012, at 1:14 PM, Craig Topper <craig.topper at gmail.com> wrote:
>>
>> > I think the other register allocators have the same cast and should be
>> fixed too.
>>
>> Even better, add MachineFunction::getName(), and stop including
>> "llvm/Function.h" in every backend pass.
>>
>> See MachineBasicBlock::getName().
>>
>> /jakob
>>
>>
>
>
> --
> ~Craig
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120821/3aedbb2d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MachineFunction_getName.patch
Type: application/octet-stream
Size: 23844 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120821/3aedbb2d/attachment.obj>


More information about the llvm-commits mailing list