[llvm-commits] [llvm] r162131 - /llvm/trunk/lib/CodeGen/StackProtector.cpp

[Duncan Sands]

Hi Chad, thanks for doing this.

>>>>> By the way can you please take a look at PR9673 which is just teaching clang to
>>>>> turn gcc's ssp-buffer-size option into LLVM's -stack-protector-buffer-size
>>>>> (llvm-gcc has done this for ages).  This is important for Debian since there are
>>>>> nearly 100 Debian packages which use ssp-buffer-size and are compiled with
>>>>> -Werror.  They fail to compile due to clang warning "unused argument during
>>>>> compilation" about ssp-buffer-size.
>>>>>
>>>
>>> Duncan,
>>> How do the attached patches look?
>>>
>>> <pr9673.clang.patch><pr9673.llvm.patch>
>>>
>>> Still needs a llvm codegen test, but should be working..
>>>
>> Chad,
>>
>> Make sure that other front-ends -- llc and tools/lto -- are setting this parameter too.
>
> Revised llvm patch attached.  Unmodified clang patch attached for reference.

The LLVM parts look good to me.

Ciao, Duncan.