[llvm-commits] [PATCH 1/4] Profile metadata: Move enum

[Manman Ren]

Looks good to me.

Thanks,
Manman

On Aug 18, 2012, at 6:27 AM, Alastair Murray wrote:

> Hello all,
> 
> Please review the attached patch.
> 
> This is the first of four patches to support setting branch weight metadata by profiling.
> 
> This is a small patch to move a single enum out of ProfileInfoTypes.h into a new ProfileDataTypes,h header.  This is done so as patches #2-#4 can be submitted without waiting for ProfileInfo removal.  With this patch the old and new profiling code can exist side-by-side.
> 
> This also means that the libprofile runtime code and the insert-edge-profiling pass do not depend on ProfileInfo.  Note that is *not* the case for insert-optimal-edge-profiling, it heavily depends on ProfileInfo and the profile loader to follow in patch #2 does not support loading optimal-edge-profiling data.
> 
> Regards,
> Alastair Murray
> <weights_1_move_enum.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits