[llvm-commits] [patch] Use the new edge dominance functions in GVN

[Chris Lattner]

On Aug 15, 2012, at 5:42 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> The results show that, at least on the current implementation, eager
> edge splitting is the most expensive option.

That matches my intuition :)

> I would like the attached patch a lot more if I was able to assert in
> Dominance.cpp that we are not given a multiple edge, but I have to
> refactor the verifier a bit before it can be done.
> 
> So I would like to propose
> 
> * We go with the attached patch for now.
> * I will try to change the verifier so it doesn't try to check
> dominance on an invoke it already knows is broken. With that we should
> be able to assert in Dominance.cpp that we are not passed multiple
> edges.
> * I will try to look at cases where GVN split egdes to see if can be avoided.

Sounds great to me if no one objects.

-Chris