[llvm-commits] [cfe-commits] [PATCH] AddressSanitizer Initialization Order Checking

[Eric Christopher]

On Aug 16, 2012, at 1:05 AM, Kostya Serebryany <kcc at google.com> wrote:

> +llvm-commits
> 
> Reid, 
> 
> The LLVM and compiler-rt patches look good. 
> Please fix the remaining small issues (see my code review comments) and commit. 
> Hold on with the output tests for a bit since Alexey Samsonov is migrating them to cmake (please coordinate with him and commit as a separate patch). 
> 
> The stress test should contain X files, Y linker initialized globals and Z dynamically initialized globals. 
> Such test only makes sense where all 3 numbers are large. 
> I guess you can commit a single .sh script into compiler-rt/lib/asan/scripts

The metadata should at least be prefixed with something like llvm.asan.<whatever> instead of just the name. That way it's more identifiable.

What's the idea behind the metadata use anyhow?

-eric