[llvm-commits] [LNT] r161836 - /lnt/trunk/lnt/server/ui/templates/v4_global_status.html

[Daniel Dunbar]

On Mon, Aug 13, 2012 at 9:20 PM, Michael Gottesman <mgottesman at apple.com> wrote:
> Author: mgottesman
> Date: Mon Aug 13 23:20:51 2012
> New Revision: 161836
>
> URL: http://llvm.org/viewvc/llvm-project?rev=161836&view=rev
> Log:
> [LNT] v4_global_status: Added machine control panel which allows you to selectively hide specific machines.
>
> *NOTE* This control panel is not wired up in this commit.

Again, I find this a weird level to dice commits at (and it makes it
very hard to review, I have to jump back and forth between patches).

To me, it would make much more sense if the entire feature of
"enable/disable machine columns" came in as one patch. I appreciate
factoring any other support work that isn't directly relevant to that
feature out, to keep that patch small, but a separated patch like this
isn't useful.

 - Daniel

> Modified:
>     lnt/trunk/lnt/server/ui/templates/v4_global_status.html
>
> Modified: lnt/trunk/lnt/server/ui/templates/v4_global_status.html
> URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/templates/v4_global_status.html?rev=161836&r1=161835&r2=161836&view=diff
> ==============================================================================
> --- lnt/trunk/lnt/server/ui/templates/v4_global_status.html (original)
> +++ lnt/trunk/lnt/server/ui/templates/v4_global_status.html Mon Aug 13 23:20:51 2012
> @@ -40,6 +40,14 @@
>    <div id="right-king-control" class="control-panel">
>    </div>
>    <div id="left-king-control" class="control-panel">
> +    <h3>Toggle Machine Visibility</h3>
> +    <div id="toggle-machine-control-panel">
> +      <ul>
> +        {% for m in machines %}
> +        <li><input machine="{{ m.name }}" id="checkbox-{{ m.get_css_name() }}" checked="checked" type="checkbox" onclick="toggle_column_visibility('{{ m.get_css_name() }}');">{{ m.name }}</input></li>
> +        {% endfor %}
> +      </ul>
> +    </div>
>    </div>
>  </div>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits