[llvm-commits] [PATCH] Add support for fast calling convention

[Renato Golin]

On 15 August 2012 13:15, Jush Lu <jush.msn at gmail.com> wrote:
> The first patch “fast-isel-fastcc.patch”:
> This patch adds support for fastcc, and I add test cases for {VFP, noVFP} x
> {fastcc, nofastcc}.

Hi Jush,

This patch looks good, and you have some tests. You could have used
regular expressions to match any S* register, but I guess it'll always
hit S0 on such a simple case. I'm not too concerned about this.


> The second patch “fast-isel-simplify-if.patch”:
> This patch just simplify if statements for CallingConv::C, no functionality
> changes.

I don't think this is a good clean-up, since it doesn't solve the
major problem, which is code duplication between the Fast and C
calling conventions that you introduce in your previous patch. I
appreciate that the similarities are not direct and obvious, so I'm
happy to accept the first patch as it is, but I think you should
re-think on the clean-up and remove the duplication.

If no one has any other objections, you can commit the bug-fix now and
send a better clean-up later.


-- 
cheers,
--renato

http://systemcall.org/