[llvm-commits] [RFC] PPC64 TOC and MCJIT support

[Adhemerval Zanella]

On 08/08/2012 03:20 PM, Roman Divacky wrote:
> On Wed, Aug 08, 2012 at 02:30:15PM -0300, Adhemerval Zanella wrote:
>> On 08/06/2012 03:49 PM, Roman Divacky wrote:
>>> Wow, this looks awesome, some parts of this (adding of enums and handling them)
>>> can be committed as is. Maybe you can split them into logical chunks? Ie.
>>> "Handle ELF::PPC{64} in ELF" etc. The TOC handling changes look fine to me.
>>> The LDtoc* stuff too. I cant comment on the JIT part.
>> Ok, I'll finish some work on relocation before. I found out that for small toc
>> model, the one I'm targeting now, it need some adjustments. I will also split
>> up the patch in parts, maybe one for changes in 'include/llvm', another for
>> TOC relocation and another fro JIT support.
>
> Ok, but please split the patch into logical chunks not only dirs. 

I'll do it, thanks.

>
> I am not questioning your change, I just think that mine is better :)
> First, it doesnt blindly create the symbol, but reuses one if it already
> exists and second, it enables the use of the integrated asm to directly 
> produce object files. Can you test if it works for you? If so, I'd prefer
> my change.
>
> Thank you! roman
>
Your suggestion is indeed better, I'm using it in next set of patches.


-- 
Adhemerval Zanella Netto
  Software Engineer
  Linux Technology Center Brazil
  Toolchain / GLIBC on Power Architecture
  azanella at linux.vnet.ibm.com / azanella at br.ibm.com
  +55 61 8642-9890