[llvm-commits] [PATCH]Convert vmov instructions between GPR and S registers for Cortex-A9

[Tim Northover]

Hi Anton,

Silviu is on holiday this week, so I'm going to be responding to his
recent reviews. I hope that's ok.

> 1. inside getExecutionDomain() make a common if (CortexA9) switch.
> Also please put the comment why the change is profitable on A9 only.

Done. Though it's more a brute fact derived from benchmarking than
something explainable in a comment.

> 2. I really do not like stuff like this:
> +      DReg = ARM::D0 + ((DstReg - ARM::S0) >> 1);

Good point. I think I've found a nice neat solution using getMatchingSuperReg.

I've also (since the mail/patch I sent just to you by mistake
yesterday) reassessed the flag-setting slightly. In particular I think
isKill should be checked on the Src rather than Dst.

Let me know if the new patch is acceptable.

Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Implement-execution-domains-for-int-FP-moves-on-ARM.patch
Type: application/octet-stream
Size: 10697 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120814/237ccd99/attachment.obj>