[llvm-commits] Patch to implement UMLAL/SMLAL Instructions for the ARM Architecture

[Arnold Schwaighofer]

I reverted the patch in r161736. I'll investigate this on Monday.

On Saturday, August 11, 2012, Michael Gottesman wrote:

> This patch caused an execution correctness error for test
> MultiSource/Applications/JM/ldecod/ldecod. The specific error that occurs
> is that the output image differs from the expected result image beyond a
> certain tolerance. The error occurs on armv7 thumb O0 g and armv7 thumb O3.
>
> On Aug 8, 2012, at 5:18 PM, Evan Cheng <evan.cheng at apple.com> wrote:
>
> >
> > On Aug 7, 2012, at 8:59 AM, Arnold Schwaighofer <arnolds at codeaurora.org>
> wrote:
> >
> >> Updated patch. Removed unused RLo, RHi. Added test cases (forgot to add
> them to the index before).
> >>
> >> Okay to commit?
> >
> > Yes.
> >
> > Evan
> >
> >>
> >> On 8/5/2012 5:28 PM, Arnold Schwaighofer wrote:
> >>> Yes, you are right - that must have been an oversight. I'll remove them
> >>> before commiting.
> >>> Thanks for catching this.
> >>>
> >>>
> >>>> +class AsMla1I64<bits<7>  opcod, dag oops, dag iops, InstrItinClass
> itin,
> >>>> +             string opc, string asm, list<dag>  pattern>
> >>>> +  : AsMul1I<opcod, oops, iops, itin, opc, asm, pattern>  {
> >>>> +  bits<4>  RdLo;
> >>>> +  bits<4>  RdHi;
> >>>> +  bits<4>  Rm;
> >>>> +  bits<4>  Rn;
> >>>> +  bits<4>  RLo;
> >>>> +  bits<4>  RHi;
> >>>> +  let Inst{19-16} = RdHi;
> >>>> +  let Inst{15-12} = RdLo;
> >>>> +  let Inst{11-8}  = Rm;
> >>>> +  let Inst{3-0}   = Rn;
> >>>> +}
> >>>>
> >>>> Hi Arnold,
> >>>>
> >>>> Here it seems that RLo and RHi are useless in this class, right? If
> it's
> >>>> no, could you please point me where they are being referenced?
> >>>>
> >>>> Thanks,
> >>>> -Jiangning
> >>>>
> >>>> 在 2012-8-2，下午10:57，Arnold Schwaighofer<arnolds at codeaurora.org>
> >>>> 写道：
> >>>>
> >>>>> Patch to implement UMLAL/SMLAL Instructions for the ARM Architecture
> >>>>>
> >>>>> This patch corrects the definition of umlal/smlal instructions and
> adds
> >>>>> support for matching them to the ARM dag combiner.
> >>>>>
> >>>>>
> >>>>>
> >>>>> This patch got lost on my end. Sorry.
> >>>>>
> >>>>> Is it okay to commit?
> >>>>>
> >>>>> Prior discussion:
> >>>>>
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120507/142351.html
> >>>>>
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120416/141153.html
> >>>>>
> >>>>> Bug:
> >>>>> http://llvm.org/bugs/show_bug.cgi?id=12213
> >>>>>
> >>>>>> I understand Anton has not gotten back to you. That's fine, I don't
> >>>>>> think
> >>>>>> you need to wait for him. However, it looks like Arnold has some
> >>>>>> concerns
> >>>>>> about the patch? Please address his concerns first.
> >>>>>>
> >>>>>> Once you have addressed Arnold's concerns, he can commit it for you.
> >>>>>> Arnold has commit privilege.
> >>>>>>
> >>>>>> Evan
> >>
> >>
> >> <yinmas_mla2.patch>_______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.<http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120812/cb9bd15a/attachment.html>