[llvm-commits] [PATCH] fix PR13577, an issue caused by r161687

[Chandler Carruth]

On Sat, Aug 11, 2012 at 4:20 PM, Michael Liao <michael.liao at intel.com>wrote:

> On Sat, 2012-08-11 at 16:06 -0700, Chandler Carruth wrote:
> > On Sat, Aug 11, 2012 at 3:49 PM, Michael Liao <michael.liao at intel.com>
> > wrote:
> >         Hi
> >
> >         Sorry, PR13577 and recent failures of compiler-rt failures is
> >         introduced
> >         by r161687. The root cause is that FCMOV (only used for 80-bit
> >         double)
> >         only supports a subset of X86 conditions. The attached patch
> >         fixes that
> >         by checking whether it's a CMOV on f80 and whether the
> >         condition is
> >         valid. A minimal test case (copysign) for PR13577 is also
> >         added.
> >
> >
> > Hmm, my diagnosis of that PR may have been a bit off -- you should
> > check whether this patch actually fixes it, as it seems to potentially
> > predate r161687. Fixing it may however re-use this logic.
> >
>
> I could compile lib/divxc3.c with llvm/clang with this patch. I also
> checked out r161491 (no r161493 in llvm itself) and cannot reproduce
> that issue. I could confirm that issue (PR13577) is caused by r161687
> alone.


Awesome. =] Please update the PR with this info and close it when you
submit! Thanks for the fast fix!! =D
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120811/f89d6e7c/attachment.html>