[llvm-commits] [llvm] r161658 - /llvm/trunk/lib/Support/Unix/PathV2.inc

[Rafael Espíndola]

Has this patch been reviewed?

What is the path that is including stdio.h? Should it include cstdio instead?

On 10 August 2012 06:56, Joerg Sonnenberger <joerg at bec.de> wrote:
> Author: joerg
> Date: Fri Aug 10 05:56:09 2012
> New Revision: 161658
>
> URL: http://llvm.org/viewvc/llvm-project?rev=161658&view=rev
> Log:
> stdcxx's cstdio doesn't include stdio.h, but the code using PathV2.inc
> includes both. Deal with feof and ferror potentially being macros.
>
> Modified:
>     llvm/trunk/lib/Support/Unix/PathV2.inc
>
> Modified: llvm/trunk/lib/Support/Unix/PathV2.inc
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Unix/PathV2.inc?rev=161658&r1=161657&r2=161658&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Support/Unix/PathV2.inc (original)
> +++ llvm/trunk/lib/Support/Unix/PathV2.inc Fri Aug 10 05:56:09 2012
> @@ -50,6 +50,12 @@
>  #include <limits.h>
>  #endif
>
> +// Both stdio.h and cstdio are included via different pathes and
> +// stdcxx's cstdio doesn't include stdio.h, so it doesn't #undef the macros
> +// either.
> +#undef ferror
> +#undef feof
> +
>  // For GNU Hurd
>  #if defined(__GNU__) && !defined(PATH_MAX)
>  # define PATH_MAX 4096
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits