[llvm-commits] [PATCH] Add support for fast calling convention

[Jush Lu]

Hi,

For  {VFP, noVFP } x { fastcc, none },  only VFP x fastcc gets wrong
result, others will work properly.

Yes, disabling VFP will solve the problem, but VFP is very common, so I
would make a patch to fix it.

Jush

On Fri, Aug 10, 2012 at 6:18 PM, Renato Golin <rengolin at systemcall.org>wrote:

> On 9 August 2012 12:53, Jush Lu <jush.msn at gmail.com> wrote:
> > Currently ARMFastISel handles fastcc for caller side by simply falling
> > through to other calling conventions such as CC_ARM_AAPCS, but the callee
> > with fastcc always uses CC_ARM_AAPCS_VFP calling convention if VFP2 is
> > available. This inconsistency of calling conventions will make problems,
> and
> > this patch will fix it as well.
>
> Hi,
>
> You don't seem to be testing all cases. You should at least test {
> VFP, noVFP } x { fastcc, none }, so adding some llc with VFP disabled
> (or on older cores) would solve that.
>
>
> --
> cheers,
> --renato
>
> http://systemcall.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120810/f6a2ddcb/attachment.html>