[llvm-commits] [patch] Invalid alignments for NEON loads

[Renato Golin]

Hi Tim,

I'm no table-gen expert, but it looks as you're using the right
patterns this time.


On 10 August 2012 10:12, Tim Northover <t.p.northover at gmail.com> wrote:
> 1. extload.diff makes LLVM use the correct NEON loads for extloadv*
> patterns. Before, we would use vld1.32 for everything from a 16-bit
> load to a 64-bit load (my own fault, embarrassingly). With this patch
> we'll select the correct version (I believe).

At least for the tests you have, it should be all right.

Are those tests offering good coverage on the bug you're fixing, or is
this met by other tests already in the suite?


> 2. vld1-align.diff: as before this brings assembly printing in line
> with object emission. Unfortunately, with the change above I can no
> longer find a way to trigger this code-path so there's no regression
> test.

The code looks correct, but it's always good to have at least a hint for a test.

Can't you disassemble and re-assemble from binary, like the MC hammer tests do?

-- 
cheers,
--renato

http://systemcall.org/