[llvm-commits] Fix cmake for Hexagon cross compilers
Sebastian Pop
spop at codeaurora.org
Wed Aug 8 11:07:02 PDT 2012
On Wed, Aug 8, 2012 at 12:50 PM, Sebastian Pop <spop at codeaurora.org> wrote:
> On Tue, Aug 7, 2012 at 10:22 AM, Douglas Gregor <dgregor at apple.com> wrote:
>>
>> On Aug 6, 2012, at 11:31 PM, Chandler Carruth <chandlerc at google.com> wrote:
>>
>> On Mon, Aug 6, 2012 at 11:16 PM, Douglas Gregor <dgregor at apple.com> wrote:
>>>
>>>
>>> On Aug 6, 2012, at 1:11 PM, Sebastian Pop <spop at codeaurora.org> wrote:
>>>
>>> > Ping^4.
>>> >
>>> > Hi, I'm waiting for a month now for an OK to commit.
>>> > It seems that really nobody except me cares for this change.
>>> > Does it really matter to somebody if I'm pushing this change out to svn?
>>> >
>>> > How should I proceed in timeout cases like this?
>>>
>>> Patch looks good, please go ahead and commit. If this happens again,
>>> please CC me. If I can't review the patch, I'll find someone who can. Sorry
>>> about that!
>>
>>
>> It's also largely my fault. I've been neglecting CMake patches. =/ Sebastian
>> pinged me on IRC and I still didn't get to it.
>>
>> FWIW, the first patch makes perfect sense.
>
> Thanks, committed as r161504.
Reverted as it broke some build bots. I will investigate and send
back an updated patch.
Sebastian
--
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum
More information about the llvm-commits
mailing list