[llvm-commits] Mips Assembler stubs for llvm

[Rafael Espíndola]

On 23 July 2012 08:50, Medic, Vladimir <vmedic at mips.com> wrote:
> Hi all,
> please find attached the updated version of the patch for Mips assembler
> stub version. It clears a trailing white space error from the previous
> patch.
> Looking forward to your comments on it.


Looks like you are still missing some unimplemented errors:

+ virtual void print(raw_ostream &OS) const {}

+  // This should be omitted for Mips target
+  if (Target.getName().find("Mips") == std::string::npos)
   emitMatchRegisterName(Target, AsmParser, OS);

So, will the call to emitMatchRegisterName fail or just produce a
bogus implementation? If it just produces a bogus one, making tablegen
print it with __attribute__((unused)) is fine. You can add the
attribute for all targets, as it just avoids a warning if the function
is unused.

If tablegen fails to produce the matcher, please add a flag to the .td
files (ShouldEmitRegisterMatcher?) and use that instead of checking
for "Mips" in the target string.

> Vladimir
> ________________________________

Cheers,
Rafael