[llvm-commits] [PATCH]Convert vmov instructions between GPR and S registers for Cortex-A9
Silviu Baranga
silbar01 at arm.com
Wed Aug 8 03:59:06 PDT 2012
Hi Anton,
Here's a new version of the patch. I've fixed a few problems that the
old patch had (the def/kill flags were not correctly set).
> Make sure you're following LLVM style guidelines, e.g. no tabs, "&&"
> inside ifs are left on preceding lines, etc.
>
> You have many whitespace changes (spaces => tabs) in your patch which
> makes reviewing harder.
I couldn't find any tabs in the patch. I did add a switch statement
which changed the indentation for some code. I've fixed the other
style issues.
Thanks,
Silviu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vmov32.diff
Type: application/octet-stream
Size: 9326 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120808/1a23adcf/attachment.obj>
More information about the llvm-commits
mailing list