[llvm-commits] [PATCH] Review request: Lazy compilation for MCJIT

[Jim Grosbach]

Hi Andy,

This looks fine to me.

Just one trivial style nit. In a couple places, there's braces around a single-statment if body that can be omitted. For example,
if (!isCompiled) {
  emitObject(M);
}

-Jim



On Aug 2, 2012, at 2:11 PM, "Kaylor, Andrew" <andrew.kaylor at intel.com> wrote:

> Hi everyone,
>  
> The attached patch implements lazy compilation for MCJIT.  That is, the module isn’t JITed until a call is made to request a pointer to a function.
>  
> I tried to implement this in such a way as to move towards multiple module support.  There are still a few things to be cleaned up in that regard, but it seemed best to leave that for a future patch since I intend to refactor the memory ownership model somewhat extensively.
>  
> I’m not making any effort to respect the ‘CompilingLazily’ flag, since that couldn’t be changed before the constructor and so would have no meaning in MCJIT.
>  
> -Andy
>  
> <lazy-compilation.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120807/0c71f99f/attachment.html>