[llvm-commits] Request for merge: GHC/ARM calling convention.
Eric Christopher
echristo at apple.com
Thu Aug 2 17:07:19 PDT 2012
On Aug 2, 2012, at 9:09 AM, Eric Christopher <echristo at apple.com> wrote:
>
> On Aug 1, 2012, at 1:35 PM, Karel Gardas <karel.gardas at centrum.cz> wrote:
>
>> Please see attached patch and tell me if it's all right for inclusion
>> into LLVM HEAD or not and if not, what else shall I provide in order to
>> make LLVM team happy about it.
>>
>> BTW: of course, LLVM HEAD with this patch applied is already tested here
>> with GHC 7.4.2. (i.e. the compiler bootstrap well with it) and LLVM's
>> own testsuite does not reveal any new regression caused by this patch.
>
> This looks fine to me and I'll apply it later today unless Jim objects :)
>
> The workaround is interesting and probably warrants fixing something in tablegen.
I've applied this here:
M lib/Target/ARM/ARMFrameLowering.cpp
M lib/Target/ARM/ARMISelLowering.cpp
M lib/Target/ARM/ARMCallingConv.td
M lib/Target/ARM/ARMBaseRegisterInfo.cpp
M lib/Target/ARM/ARMFastISel.cpp
r161226 = 7435ecbfe7c21b038af725d8826a9a871f21ff97 (refs/remotes/origin/master)
with the quick fix Jakob suggested.
Some testcases wouldn't go amiss here though.
Thanks!
-eric
More information about the llvm-commits
mailing list