[llvm-commits] [PATCH] Review request: Allow assembly macro parameters and arguments delimited by spaces

[Zhang, Andy]

Hi all,

I have combined PaX Team's patch with mine, attached to this message. This patch adds support for delimiting assembly macro parameters and arguments with spaces to improve compatibility with GNU as, and fixes a bug where underscores in macro parameters were not recognized.

It also includes all of PaX Team's changes for macro handling (arguments in .irpc and .irp, improved error messages for macro arguments, default parameter values, nested macros) and fixes the assertion failures in that patch. There are also updated test cases.

Please review and let me know if it is ok to commit.

Thanks,
Andy

-- 
Andy Zhang andy.zhang at intel.com
  Intel Dynamic Mobility and Parallelism
  Intel Waterloo
  Phone: +1.519.772.2583



> -----Original Message-----
> From: PaX Team [mailto:pageexec at freemail.hu]
> Sent: Monday, July 16, 2012 6:32 PM
> To: llvm-commits at cs.uiuc.edu; Zhang, Andy
> Subject: Re: [llvm-commits] [PATCH] Review request: Allow assembly
> macro parameters and arguments delimited by spaces
> 
> On 16 Jul 2012 at 22:05, Zhang, Andy wrote:
> 
> > Hi PaX,
> >
> > I just saw your patch for handling parameters with underscores. But I
> > searched and didn't find a patch from you that handles parsing spaces
> > in macro parameters. Could you point me to the commit/posting date if
> > I missed it?
> 
> integrated-as-macro.patch that i submitted last week has everything:
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-
> 20120709/146195.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: macros-svn.diff
Type: application/octet-stream
Size: 26651 bytes
Desc: macros-svn.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120802/f3048058/attachment.obj>