[llvm-commits] [compiler-rt] r161168 - in /compiler-rt/trunk/lib/interception: interception.h interception_linux.cc interception_linux.h interception_mac.cc interception_mac.h

[Alexey Samsonov]

On Thu, Aug 2, 2012 at 4:38 PM, Stephen Canon <scanon at apple.com> wrote:

> On Aug 2, 2012, at 8:27 AM, Alexey Samsonov <samsonov at google.com> wrote:
>
> On Thu, Aug 2, 2012 at 4:08 PM, Joerg Sonnenberger <
> joerg at britannica.bec.de> wrote:
>
>> On Thu, Aug 02, 2012 at 11:19:13AM -0000, Alexey Samsonov wrote:
>> > Author: samsonov
>> > Date: Thu Aug  2 06:19:13 2012
>> > New Revision: 161168
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=161168&view=rev
>> > Log:
>> > [Sanitizer] Workaround for a compiler warning - ISO C++ forbids casting
>> pointer-to-function to pointer-to-object, so we use cast via integral type
>>
>> Shouldn't this be using (u)intptr_t from stdint.h?
>>
>
> Sometimes there is no stdint.h (like in Visual Studio 9).
> Also, we try to contain inclusion of system headers in headers of
> ASan/TSan runtimes as much as possible.
>
>
> IIRC, doesn't 64-bit Windows (precisely one of the cases where you might
> be lacking stdint.h) use an ILP32 model?  uintptr_t may not be perfect, but
> unsigned long doesn't seem right at all.
>

>From what I can find, longs and pointers have equal size on ILP32 and
LP64. Did you mean LLP64?
Currently we don't support 64-bit Windows, but many thanks for pointing at
this!

-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120802/7763e78c/attachment.html>