[llvm-commits] [PATCH][MIPS] MCJIT for MIPS32

[Kaylor, Andrew]

Great!  Everything else looked good to me, though I can't say I know enough about MIPS to give meaningful feedback on some of it.  Presumably you've got that part covered. :)

-Andy

-----Original Message-----
From: Jovanovic, Petar [mailto:petarj at mips.com] 
Sent: Wednesday, August 01, 2012 10:59 AM
To: Kaylor, Andrew; llvm-commits at cs.uiuc.edu
Subject: RE: [PATCH][MIPS] MCJIT for MIPS32

Hi Andy,

I have just run the test on MacOS, and no regressions with the patch.

Petar
________________________________________
From: Jovanovic, Petar
Sent: Thursday, July 26, 2012 12:26 AM
To: Kaylor, Andrew; llvm-commits at cs.uiuc.edu
Subject: RE: [PATCH][MIPS] MCJIT for MIPS32

Hi Andy,

I have run 'make check' on x86/Linux, and the results were fine. Haven't tested on Mach-O.

Regards,
Petar
________________________________________
From: Kaylor, Andrew [andrew.kaylor at intel.com]
Sent: Wednesday, July 25, 2012 8:03 PM
To: Jovanovic, Petar; llvm-commits at cs.uiuc.edu
Subject: RE: [PATCH][MIPS] MCJIT for MIPS32

Hi Petar,

Have you tested this on X86 Linux and MachO?

This particular change caught my eye:


===================================================================
--- lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp     (revision 160697)
+++ lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp     (working copy)
@@ -108,7 +108,8 @@
       CommonSymbols[*i] = Size;
     } else {
       if (SymType == object::SymbolRef::ST_Function ||
-          SymType == object::SymbolRef::ST_Data) {
+          SymType == object::SymbolRef::ST_Data ||
+          SymType == object::SymbolRef::ST_Unknown) {
         uint64_t FileOffset;
         StringRef SectionData;
         section_iterator si = obj->end_sections();


I have a vague memory of having tried adding the ST_Unknown case there before and having it break one or the other of the above-mentioned platforms.  I can't remember the specifics.  That may have been before I added the explicit common symbol handling.  Unfortunately, I haven't been able to find anything to jog my memory.

-Andy

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Jovanovic, Petar
Sent: Tuesday, July 24, 2012 7:04 PM
To: llvm-commits at cs.uiuc.edu
Subject: [llvm-commits] [PATCH][MIPS] MCJIT for MIPS32

Hi everyone

here is a patch that corrects MCJIT functionality for MIPS32 architecture.
The code has been tested on little-endian MIPS32 platform.

Petar