[llvm-commits] [llvm] r160949 - /llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp

[Craig Topper]

Author: ctopper
Date: Mon Jul 30 00:39:34 2012
New Revision: 160949

URL: http://llvm.org/viewvc/llvm-project?rev=160949&view=rev
Log:
Remove check for sub class of X86Inst from filter function since caller guaranteed it. Replace another sub class check with ShouldBeEmitted flag since it was factored in there already.

Modified:
    llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp

Modified: llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp?rev=160949&r1=160948&r2=160949&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp (original)
+++ llvm/trunk/utils/TableGen/X86RecognizableInstr.cpp Mon Jul 30 00:39:34 2012
@@ -394,8 +394,7 @@
 
   // Filter out intrinsics
 
-  if (!Rec->isSubClassOf("X86Inst"))
-    return FILTER_STRONG;
+  assert(Rec->isSubClassOf("X86Inst") && "Can only filter X86 instructions");
 
   if (Form == X86Local::Pseudo ||
       (IsCodeGenOnly && Name.find("_REV") == Name.npos))
@@ -544,7 +543,7 @@
 void RecognizableInstr::emitInstructionSpecifier(DisassemblerTables &tables) {
   Spec->name       = Name;
 
-  if (!Rec->isSubClassOf("X86Inst"))
+  if (!ShouldBeEmitted)
     return;
 
   switch (filter()) {
@@ -587,9 +586,6 @@
     }
   }
 
-  if (!ShouldBeEmitted)
-    return;
-
 #define HANDLE_OPERAND(class)               \
   handleOperand(false,                      \
                 operandIndex,               \