[llvm-commits] [lld] r160732 - /lld/trunk/lib/ReaderWriter/ELF/ReaderELF.cpp

[Sid Manning]

On 07/27/12 00:39, Nick Kledzik wrote:

>>> Also, we want Readers to cleanly return with an error_code if an errors
>> occur.   This is so that the Readers can be used as a library in some other
>> program (such as an IDE). The ReaderELF currently calls
>> llvm::report_fatal_error() which usually terminates the program.
>>>
>> No problem, I follow what ReaderCOFF does and return letting EC be dealt with by the caller.
> It is sad that this loses the message string about what is wrong with the file.   The error_code style seems to be that you need to make up unique error codes for each printed error string.  At some point we will have a better solution for this and revisit this code.
>
Is it reasonable then to extend object_error to support more granular 
error conditions?


-- 
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum